Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Experimental: Remove styles from template parts #262

Merged
merged 3 commits into from Nov 29, 2021

Conversation

carolinan
Copy link
Collaborator

Description
This is a test for "Remove color, spacing, and layout options for Template Part block" WordPress/gutenberg#36571

Screenshots

Testing Instructions
Provide steps for testing

  1. Apply Remove color, spacing, and layout options for Template Part block gutenberg#36571
  2. (Make sure you remove any saved template or template part changes from the install)
  3. View the editor and front. Test both the default header, and the two dark headers.

Known issues:

  • A bottom padding below the header was removed on 404
  • There are spacing inconsistencies between the default header and the two black headers, on smaller screen widths.
  • Footer and header patterns are untested.

@carolinan carolinan marked this pull request as ready for review November 24, 2021 08:00
@kjellr
Copy link
Collaborator

kjellr commented Nov 24, 2021

Thanks for getting this started, @carolinan! I pushed a couple small fixes for these items:

  • A bottom padding below the header was removed on 404
  • There are spacing inconsistencies between the default header and the two black headers, on smaller screen widths.

As for the patterns, I expect that a few of them might need adjustments, but that can be handled separately. I think this PR is ready for when/if WordPress/gutenberg#36571 lands. 👍

Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress/gutenberg#36571 has been merged upstream, so I'll merge this in too. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants