Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TT1 Blocks editor block margins and add appearanceTools support #301

Conversation

ironprogrammer
Copy link
Contributor

This setting activates block editor-controlled margins for TT1 Blocks. Resolves zeroed margin issue for vertically adjacent blocks in editor.

Also enables additional style control support, included in WordPress 5.9.

BEFORE FIX: Adjacent Buttons blocks with no vertical margin:

tt1-blocks_appearanceTools-disabled-default

AFTER FIX: Default vertical margins applied by block editor for adjacent Buttons blocks:

tt1-blocks_appearanceTools-enabled

Testing:

  • Update tested to resolve display issue (screens above via a4be989).
  • Update tested to confirm appearanceTools features remain enabled after removing manual settings (7a41a38).

References:

Related:

This setting activates block editor-controlled margins. Resolves zeroed margin issue for vertically adjacent blocks in editor.

Also enables additional style control support, included in WordPress 5.9.
Removes settings that are enabled by default via `appearanceTools` option.

See: https://make.wordpress.org/core/2022/01/08/updates-for-settings-styles-and-theme-json/
@ironprogrammer ironprogrammer changed the title 54250 fix t11 blocks editor group margins Fix T11 Blocks editor group margins and add appearanceTools support Feb 4, 2022
@ironprogrammer ironprogrammer changed the title Fix T11 Blocks editor group margins and add appearanceTools support Fix T11 Blocks editor block margins and add appearanceTools support Feb 4, 2022
@kjellr
Copy link
Collaborator

kjellr commented Feb 4, 2022

Thanks!

@kjellr kjellr merged commit 13ccf7b into WordPress:master Feb 4, 2022
@ironprogrammer ironprogrammer deleted the 54250-fix-t11-blocks-editor-group-margins branch February 4, 2022 17:38
@ironprogrammer ironprogrammer changed the title Fix T11 Blocks editor block margins and add appearanceTools support Fix TT1 Blocks editor block margins and add appearanceTools support Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants