Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wp-now: Recognize when running in WebContainers environment and use the correct URL #150

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

wp-now: Recognize when running in WebContainers environment and use the correct URL #150

wants to merge 3 commits into from

Conversation

adamziel
Copy link
Collaborator

Description TBD

CleanShot 2024-01-26 at 16 20 59@2x

@adamziel adamziel added Enhancement New feature or request wp-now labels Jan 26, 2024
adamziel
adamziel commented Jan 26, 2024
View reviewed changes
packages/wp-now/src/start-server.ts Outdated
@@ -103,6 +103,12 @@ export async function startServer(
),
body: body as string,
};

data.headers['host'] = options.absoluteUrl
Copy link
Collaborator Author

@adamziel adamziel Jan 26, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be handled by webcontainers, not wp-now, and removed from here.

adamziel
adamziel commented Jan 26, 2024
View reviewed changes
packages/wp-now/src/config.ts Outdated
@@ -75,6 +76,9 @@ async function getAbsoluteURL() {
if (isGitHubCodespace) {
return getCodeSpaceURL(port);
}
if (isWebContainer()) {
return HostURL.parse('http://localhost:' + port).toString();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This returns a http:// URL when it should return a https:// URL

@kirjavascript kirjavascript mentioned this pull request Apr 8, 2024
Merged
adamziel pushed a commit that referenced this pull request Apr 15, 2024
@kirjavascript
wp-now: WebContainer support fixes (#221)
3a3a4e1 
Improvements to #150
with fixes related to updates for wp-now in WebContainer

Can be retargetting to `trunk` if you want to close the other PR

## Testing Instructions

Visit https://stackblitz.com/edit/node and run 

```bash
npx @wp-now/wp-now@some-version start
```

WP-Now should load in your browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or request wp-now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adamziel