New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated code to display plugin settings link in the features screen and fix responsive layout for mobile #1208
Updated code to display plugin settings link in the features screen and fix responsive layout for mobile #1208
Conversation
…com:ashwinparthasarathi/performance into add/plugin-settings-link-in-features-screen
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @benoitfouc. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…he_next_available_hash_for_the_full_size_image_on_multiple_image_edits
…com:ashwinparthasarathi/performance into add/plugin-settings-link-in-features-screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the Settings link be moved after the Learn More link? Since not all plugins have Settings links, this will allow the Learn More link to be consistently after the button.
Something else to ponder: upon activating a plugin which has Settings, it would be a nice touch to do some yellow-fade or some other styling effect to highlight the fact that there is a Settings link now after the page reloaded which wasn't there before. Not sure what would be the most in-line with existing core designs. |
Understood, made changes to move the link down as the last in the action items.
If you could point me to a reference, I can figure out an appropriate design cue to highlight the settings link freshly added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashwinparthasarathi @westonruter, I believe we should postpone this to the next release. In issue #1032, we're investigating the activation of all active plugins (whether stable or experimental). Consequently, we would need to refactor this code significantly. Do these code changes support the activation of multiple plugins?
@mukeshpanchal27 No, it doesn't support multiple plugin activation, since this screen doesn't support that yet. But I don't think it would be so relevant as then all of the settings links would appear together all at once. I think we can land this in 3.1.0 and then refactor as part of the bulk-activation and also Ajax activation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This will really improve discoverability of the features' settings.
With 57e0f8e, compare the responsive layout of the feature cards: BeforeScreen.recording.2024-05-16.11.45.09.webmAfterScreen.recording.2024-05-16.11.45.57.webmTake note of the addition of the Settings link here, including how a divider appears when the links are presented horizontally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Nice job.
Summary
Fixes #1137
Relevant technical choices
Result
Update: See #1208 (comment) for how the responsive layout is also fixed for mobile.