Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse WP_HTML_Processor::is_void() now that WP 6.5 is minimum supported version #1115

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

westonruter
Copy link
Member

This removes a TODO to reuse WP_HTML_Processor::is_void() instead of replicating that functionality which was not available until WP 6.4. Now that 6.4 is the minimum-supported version, that method can be reused.

This could have been done previously in #1068 when the minimum version was bumped.

@westonruter westonruter added the [Type] Enhancement A suggestion for improvement of an existing feature label Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter force-pushed the update/html-processor-is-void-reuse branch from 6063786 to 34b6a27 Compare April 6, 2024 20:40
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @westonruter!

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter Actually, it looks like https://github.com/WordPress/performance/actions/runs/8583685696/job/23573872147?pr=1115 has failures related to this change. Can you check?

@westonruter westonruter force-pushed the update/html-processor-is-void-reuse branch from 01972c9 to d4611a6 Compare April 8, 2024 17:16
@westonruter westonruter force-pushed the update/html-processor-is-void-reuse branch from d4611a6 to 0f350c4 Compare April 8, 2024 17:32
@westonruter
Copy link
Member Author

@felixarntz Ah, this may have been an oversight in core that certain void tags were missed. I've opened Core-60961 to discuss that. In the meantime, probably better to let this PR sit.

@westonruter westonruter removed this from the optimization-detective 0.1.1 milestone Apr 8, 2024
@westonruter westonruter marked this pull request as draft April 8, 2024 17:40
@felixarntz
Copy link
Member

@westonruter SG. We should probably set the base to trunk then.

@westonruter westonruter changed the base branch from release/3.0.0 to trunk April 8, 2024 18:19
@westonruter
Copy link
Member Author

Oh, and actually WP_HTML_Processor::is_void() was updated in 6.5 to include these deprecated void tags. So it's just that the version in 6.4 doesn't include them. So unless the change is backported to 6.4, this PR will have to wait until 6.5 is the minimum-supported version.

@swissspidy swissspidy changed the title Reuse WP_HTML_Processor::is_void() now that WP 6.4 is minimum supported version Reuse WP_HTML_Processor::is_void() now that WP 6.5 is minimum supported version May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants