-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus the trigger when content setting modal is closed #4338
Conversation
6643e57
to
9660fae
Compare
import VSearchBarButton from "~/components/VHeader/VHeaderMobile/VSearchBarButton.vue" | ||
|
||
export default { | ||
export default defineComponent({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is necessary for the type in VHeaderMobile
to work (ref<InstanceType<typeof VContentSettingsButton>>
)
Do you mind adding testing instructions for this PR @obulat? |
Sorry, I've written the reproduction in the issue, and must have mixed that with the testing instructions :) Updated now. |
cca7b01
to
969b701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! #3195 was distracting while testing 😆 but nice work.
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
969b701
to
d8793b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly, I'm not able to see any difference between prod and my local copy when testing this 🤔 But the code looks good!
Fixes
Fixes #4337 by @obulat
Description
This PR adds the
triggerElement
prop to theVInputModal
's modal content to focus the trigger when modal is hidden.In addition, it also fixes the search bar button: when they are focused, only the inner focus ring is visible instead of the current broken two rings:
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.just catalog/generate-docs
for catalogPRs) or the media properties generator (
just catalog/generate-docs media-props
for the catalog or
just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin