Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus the trigger when content setting modal is closed #4338

Merged
merged 2 commits into from
May 17, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 15, 2024

Fixes

Fixes #4337 by @obulat

Description

This PR adds the triggerElement prop to the VInputModal's modal content to focus the trigger when modal is hidden.
In addition, it also fixes the search bar button: when they are focused, only the inner focus ring is visible instead of the current broken two rings:

Screenshot 2024-05-15 at 8 14 15 PM

Testing Instructions

  1. Go to http://localhost:8443/search?q=cat, and narrow your screen to mobile width.
  2. Click on the content settings button inside the search bar.
  3. Press Tab
  4. The content setting button should be focused (with a pink ring around it).
  5. Compare this with the production: on openverse.org/search?q=cat, follow the same steps. Nothing should look focused. If you press Tab again, you'll see that "Skip to content" button is focused, which shows that the body was focused when the modal was hidden.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (just catalog/generate-docs for catalog
    PRs) or the media properties generator (just catalog/generate-docs media-props
    for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner May 15, 2024 17:24
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label May 15, 2024
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels May 15, 2024
@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label May 15, 2024
@obulat obulat force-pushed the fix/search-bar-button-content-settings-modal branch 2 times, most recently from 6643e57 to 9660fae Compare May 15, 2024 17:29
import VSearchBarButton from "~/components/VHeader/VHeaderMobile/VSearchBarButton.vue"

export default {
export default defineComponent({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary for the type in VHeaderMobile to work (ref<InstanceType<typeof VContentSettingsButton>>)

@obulat obulat self-assigned this May 15, 2024
@AetherUnbound
Copy link
Contributor

Do you mind adding testing instructions for this PR @obulat?

@obulat
Copy link
Contributor Author

obulat commented May 16, 2024

Do you mind adding testing instructions for this PR @obulat?

Sorry, I've written the reproduction in the issue, and must have mixed that with the testing instructions :) Updated now.

@obulat obulat force-pushed the fix/search-bar-button-content-settings-modal branch from cca7b01 to 969b701 Compare May 16, 2024 16:24
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! #3195 was distracting while testing 😆 but nice work.

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat force-pushed the fix/search-bar-button-content-settings-modal branch from 969b701 to d8793b8 Compare May 17, 2024 17:42
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly, I'm not able to see any difference between prod and my local copy when testing this 🤔 But the code looks good!

@obulat obulat merged commit ac480fd into main May 17, 2024
44 checks passed
@obulat obulat deleted the fix/search-bar-button-content-settings-modal branch May 17, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The content settings button should be focused when the modal is hidden
4 participants