Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the skip-to-content button #4336

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix the skip-to-content button #4336

merged 1 commit into from
May 17, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 15, 2024

Fixes

Fixes #4335 by @obulat

Description

This PR fixes the skip-to-content button.

I didn't add the snapshot tests so that we don't have too many. I could add if the reviewers think this necessary.

Testing Instructions

Run the app and press Tab. The skip to content button should not be full-width and should look correctly.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (just catalog/generate-docs for catalog
    PRs) or the media properties generator (just catalog/generate-docs media-props
    for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label May 15, 2024
@obulat obulat self-assigned this May 15, 2024
@obulat obulat requested a review from a team as a code owner May 15, 2024 17:12
@openverse-bot openverse-bot added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility labels May 15, 2024
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when run locally!

Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat force-pushed the fix/skip-to-content-button branch from 63937da to 36c97c8 Compare May 16, 2024 16:24
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The homepage doesn't look great with the visible focus state on #content, but I'll make a new issue for that.

@obulat obulat merged commit 30f1df1 into main May 17, 2024
44 checks passed
@obulat obulat deleted the fix/skip-to-content-button branch May 17, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Skip-to-content button is broken
4 participants