-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document retired node replacement in ES #4326
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/4326 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. Changed files 🔄: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this documentation! It all makes sense, just a few small notes.
Drafting this PR while I:
|
@zackkrida Since the node replacement is complete, do you think we can undraft this? Even if we eventually move this to a playbook, it'd be good to have the documentation in the meantime just in case, IMO! |
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
@AetherUnbound it's updated, undrafted, and ready for review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@zackkrida do you plan to create an issue to convert this to a playbook (with prompts as we discussed)? I think that's a good idea, and a fine interim solution for this until we can fix how we deploy Elasticsearch.
Description
This PR documents the procedure to follow for replacing a retired Elasticsearch node in our custom, self-managed Elasticsearch cluster.
Testing Instructions
Review the plan and make sure the instructions are clear.
Checklist
Update index.md
).main
) or a parent feature branch.just catalog/generate-docs
for catalogPRs) or the media properties generator (
just catalog/generate-docs media-props
for the catalog or
just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin