Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really fix import path for .mjs files #3392

Merged
merged 2 commits into from Nov 23, 2023
Merged

Really fix import path for .mjs files #3392

merged 2 commits into from Nov 23, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 23, 2023

Fixes

Follow up to #3390.

Description

This PR fixes the import path to the .mjs files by using the full path instead of relative as per a comment on this thread: actions/github-script#168 (comment) This should really fix the workflows this time.

A point of confusion is that the docs say that "type": "module" should be present in package.json but import() has been working just fine without that so far (see testing instructions in original PR #3375) so it might just work even without that field.

This PR also removes a redundant step from CI that should considerably speed up the workflow.

Testing Instructions

Compare the code changes against the attached thread.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner November 23, 2023 09:38
@dhruvkb dhruvkb added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: mgmt Related to repo management and automations labels Nov 23, 2023
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove the setup-env? Is the environment set up in a different way in automations?

@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 23, 2023

When we use actions/github-script, we don't need the environment to be set up.

@dhruvkb dhruvkb merged commit 7c1f2f5 into main Nov 23, 2023
68 checks passed
@dhruvkb dhruvkb deleted the fix_path_2 branch November 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants