Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The content settings button should be focused when the modal is hidden #4337

Closed
obulat opened this issue May 15, 2024 · 0 comments · Fixed by #4338
Closed

The content settings button should be focused when the modal is hidden #4337

obulat opened this issue May 15, 2024 · 0 comments · Fixed by #4338
Assignees
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented May 15, 2024

Description

On a narrow screen, when you close the content settings modal, the trigger (Content settings button) should be focused. Instead, the body gets the focus.

Reproduction

  1. Go to https://openverse.org/search?q=cat, and narrow your screen.
  2. Click on the content settings button inside the search bar.
  3. Press Tab
  4. See error: the content setting button is not focused. If you press Tab again, you'll see that "Skip to content" button is focused, which shows that the body was focused when the modal was hidden.
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility 🧱 stack: frontend Related to the Nuxt frontend labels May 15, 2024
@obulat obulat self-assigned this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant