Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update TypeScript version to 4.9.3 #1993

Merged
merged 4 commits into from Dec 6, 2022
Merged

Update TypeScript version to 4.9.3 #1993

merged 4 commits into from Dec 6, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 18, 2022 •
edited

Fixes

Fixes #1834 by @sarayourfriend

Description

This PR updates TS to the latest available version.

Testing Instructions

The types step in the CI should pass, along with other CI steps.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner November 18, 2022 18:17
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Nov 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1993
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1993/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Nov 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited

Size Change: +37.1 kB (+5%) 🔍

Total Size: 861 kB

Filename Size Change
./.nuxt/dist/client/231.js 0 B -272 B (removed) 🏆
./.nuxt/dist/client/231.modern.js 0 B -277 B (removed) 🏆
./.nuxt/dist/client/232.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 148 kB +18 kB (+14%) ⚠️
./.nuxt/dist/client/app.modern.js 120 kB -1.72 kB (-1%)
./.nuxt/dist/client/commons/app.js 86.6 kB -1.45 kB (-2%)
./.nuxt/dist/client/commons/app.modern.js 77.5 kB +543 B (+1%)
./.nuxt/dist/client/components/v-all-results-grid.js 7.49 kB +2.34 kB (+45%) 🚨
./.nuxt/dist/client/components/v-audio-details.js 2.53 kB +722 B (+40%) 🚨
./.nuxt/dist/client/components/v-content-report-form.js 6.08 kB +2.33 kB (+62%) 🆘
./.nuxt/dist/client/components/v-content-report-popover.js 1.23 kB -3.18 kB (-72%) 🏆
./.nuxt/dist/client/components/v-image-details.js 2.15 kB +708 B (+49%) 🚨
./.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB -11 B (-1%)
./.nuxt/dist/client/components/v-image-grid.js 4.88 kB +2.34 kB (+93%) 🆘
./.nuxt/dist/client/components/v-load-more.js 3.16 kB +2.37 kB (+300%) 🆘
./.nuxt/dist/client/components/v-related-images.js 1.05 kB -2.05 kB (-66%) 🏆
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 3.37 kB +2.38 kB (+239%) 🆘
./.nuxt/dist/client/pages/audio/_id.js 7.97 kB +3.01 kB (+61%) 🆘
./.nuxt/dist/client/pages/image/_id.js 9.28 kB +3.88 kB (+72%) 🆘
./.nuxt/dist/client/pages/index.js 7.39 kB +2.33 kB (+46%) 🚨
./.nuxt/dist/client/pages/preferences.js 1.21 kB -14 B (-1%)
./.nuxt/dist/client/pages/search.js 5.08 kB +2.36 kB (+87%) 🆘
./.nuxt/dist/client/pages/search/audio.js 6.21 kB +2.36 kB (+61%) 🆘
./.nuxt/dist/client/pages/search/image.js 660 B -2.18 kB (-77%) 🏆
./.nuxt/dist/client/runtime.js 2.62 kB -82 B (-3%)
./.nuxt/dist/client/runtime.modern.js 2.61 kB -83 B (-3%)
./.nuxt/dist/client/vendors/app.js 63.4 kB +1.23 kB (+2%)
./.nuxt/dist/client/vendors/app.modern.js 62.8 kB +918 B (+1%)
./.nuxt/dist/client/215.js 272 B +272 B (new file) 🆕
./.nuxt/dist/client/215.modern.js 277 B +277 B (new file) 🆕
./.nuxt/dist/client/216.js 1.85 kB +1.85 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/components/loading-icon.js 744 B -1 B (0%)
./.nuxt/dist/client/components/loading-icon.modern.js 749 B -1 B (0%)
./.nuxt/dist/client/components/table-sort-icon.js 509 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 513 B 0 B
./.nuxt/dist/client/components/v-all-results-grid.modern.js 5.01 kB +5 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 357 B 0 B
./.nuxt/dist/client/components/v-audio-cell.modern.js 360 B 0 B
./.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB +2 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-audio-track.js 5.21 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-track.modern.js 5.16 kB +1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 538 B -2 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 544 B +1 B (0%)
./.nuxt/dist/client/components/v-bone.js 684 B 0 B
./.nuxt/dist/client/components/v-bone.modern.js 689 B 0 B
./.nuxt/dist/client/components/v-box-layout.js 1.2 kB -3 B (0%)
./.nuxt/dist/client/components/v-box-layout.modern.js 1.2 kB 0 B
./.nuxt/dist/client/components/v-content-link.js 1.11 kB -2 B (0%)
./.nuxt/dist/client/components/v-content-link.modern.js 1.09 kB +2 B (0%)
./.nuxt/dist/client/components/v-content-page.js 467 B 0 B
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 781 B +2 B (0%)
./.nuxt/dist/client/components/v-content-report-button.modern.js 784 B +2 B (0%)
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.57 kB +4 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.22 kB +4 B (0%)
./.nuxt/dist/client/components/v-copy-button.js 3.99 kB +5 B (0%)
./.nuxt/dist/client/components/v-copy-button.modern.js 4 kB +2 B (0%)
./.nuxt/dist/client/components/v-copy-license.js 998 B -2 B (0%)
./.nuxt/dist/client/components/v-copy-license.modern.js 1 kB +1 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js 9.5 kB -2 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js 9.48 kB +5 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.js 743 B -5 B (-1%)
./.nuxt/dist/client/components/v-dmca-notice.modern.js 752 B -2 B (0%)
./.nuxt/dist/client/components/v-error-image.js 1.69 kB -2 B (0%)
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB -2 B (0%)
./.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./.nuxt/dist/client/components/v-external-search-form.js 3.09 kB +1 B (0%)
./.nuxt/dist/client/components/v-external-search-form.modern.js 3.06 kB +2 B (0%)
./.nuxt/dist/client/components/v-external-source-list.js 2.55 kB +3 B (0%)
./.nuxt/dist/client/components/v-external-source-list.modern.js 2.52 kB +2 B (0%)
./.nuxt/dist/client/components/v-full-layout.js 1.59 kB 0 B
./.nuxt/dist/client/components/v-full-layout.modern.js 1.59 kB -1 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.js 1.62 kB +5 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.61 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.js 1.01 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB 0 B
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB 0 B
./.nuxt/dist/client/components/v-image-grid.modern.js 2.42 kB +1 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.js 521 B -1 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 526 B +1 B (0%)
./.nuxt/dist/client/components/v-load-more.modern.js 683 B +1 B (0%)
./.nuxt/dist/client/components/v-media-license.js 799 B -1 B (0%)
./.nuxt/dist/client/components/v-media-license.modern.js 810 B +1 B (0%)
./.nuxt/dist/client/components/v-media-reuse.js 1.62 kB -3 B (0%)
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.62 kB +3 B (0%)
./.nuxt/dist/client/components/v-media-tag.js 430 B 0 B
./.nuxt/dist/client/components/v-media-tag.modern.js 434 B 0 B
./.nuxt/dist/client/components/v-no-results.js 2.75 kB +5 B (0%)
./.nuxt/dist/client/components/v-no-results.modern.js 2.72 kB +2 B (0%)
./.nuxt/dist/client/components/v-radio.js 1.51 kB -7 B (0%)
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB +1 B (0%)
./.nuxt/dist/client/components/v-related-audio.js 1.23 kB -2 B (0%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.23 kB -2 B (0%)
./.nuxt/dist/client/components/v-related-images.modern.js 2.98 kB +1 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.js 966 B +1 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.modern.js 967 B +4 B (0%)
./.nuxt/dist/client/components/v-row-layout.js 1.7 kB -4 B (0%)
./.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB 0 B
./.nuxt/dist/client/components/v-scroll-button.js 812 B -1 B (0%)
./.nuxt/dist/client/components/v-scroll-button.modern.js 818 B -1 B (0%)
./.nuxt/dist/client/components/v-search-grid.js 5.43 kB +4 B (0%)
./.nuxt/dist/client/components/v-search-grid.modern.js 5.39 kB +5 B (0%)
./.nuxt/dist/client/components/v-search-results-title.js 659 B +3 B (0%)
./.nuxt/dist/client/components/v-search-results-title.modern.js 657 B +4 B (+1%)
./.nuxt/dist/client/components/v-search-type-radio.js 793 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.modern.js 770 B -1 B (0%)
./.nuxt/dist/client/components/v-server-timeout.js 299 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sidebar-target.js 318 B +1 B (0%)
./.nuxt/dist/client/components/v-sidebar-target.modern.js 321 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 894 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.js 887 B -1 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 896 B +2 B (0%)
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB -1 B (0%)
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB +1 B (0%)
./.nuxt/dist/client/components/v-sources-table.js 15.7 kB -3 B (0%)
./.nuxt/dist/client/components/v-sources-table.modern.js 15.8 kB +1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.js 298 B -1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 302 B -1 B (0%)
./.nuxt/dist/client/pages/about.js 1.14 kB +1 B (0%)
./.nuxt/dist/client/pages/about.modern.js 1.14 kB 0 B
./.nuxt/dist/client/pages/audio/_id.modern.js 4.8 kB +7 B (0%)
./.nuxt/dist/client/pages/external-sources.js 1.52 kB -1 B (0%)
./.nuxt/dist/client/pages/external-sources.modern.js 1.53 kB -1 B (0%)
./.nuxt/dist/client/pages/feedback.js 1.31 kB -1 B (0%)
./.nuxt/dist/client/pages/feedback.modern.js 1.31 kB -4 B (0%)
./.nuxt/dist/client/pages/image/_id.modern.js 7.34 kB +2 B (0%)
./.nuxt/dist/client/pages/index.modern.js 4.92 kB -1 B (0%)
./.nuxt/dist/client/pages/preferences.modern.js 1.21 kB +2 B (0%)
./.nuxt/dist/client/pages/search-help.js 1.62 kB 0 B
./.nuxt/dist/client/pages/search-help.modern.js 1.61 kB 0 B
./.nuxt/dist/client/pages/search.modern.js 2.57 kB +1 B (0%)
./.nuxt/dist/client/pages/search/audio.modern.js 3.74 kB -2 B (0%)
./.nuxt/dist/client/pages/search/image.modern.js 2.73 kB +1 B (0%)
./.nuxt/dist/client/pages/search/index.js 540 B -1 B (0%)
./.nuxt/dist/client/pages/search/index.modern.js 545 B -2 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js 243 B +1 B (0%)
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./.nuxt/dist/client/pages/search/video.js 239 B -1 B (0%)
./.nuxt/dist/client/pages/search/video.modern.js 243 B 0 B
./.nuxt/dist/client/pages/sources.js 1.52 kB -1 B (0%)
./.nuxt/dist/client/pages/sources.modern.js 1.51 kB 0 B

compressed-size-action

sarayourfriend
sarayourfriend approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we'll need to update prettier and eslint (and TypeScript parsers) to get the latest syntaxes like satisfies etc.

@obulat obulat marked this pull request as draft November 21, 2022 03:40
@openverse-bot openverse-bot moved this from Needs review to In progress in Openverse PRs Nov 21, 2022
@obulat
Copy link
Contributor Author

obulat commented Nov 21, 2022 •
edited

This PR is blocked by the support of TS 4.9 by ESLint and Prettier:

The upstream dependencies have been updated, so I've updated the PR, too.

@obulat obulat marked this pull request as ready for review November 24, 2022 13:49
@openverse-bot openverse-bot moved this from In progress to Needs review in Openverse PRs Nov 24, 2022
sarayourfriend
sarayourfriend approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested the changes to the focus trap by manually testing the modal behaviour in Storybook.

There's one bit of left over testing code but not blocking so that you're not waiting for a second approval after removing it 👍

test/unit/specs/components/v-modal.spec.js Outdated Show resolved Hide resolved
@obulat @sarayourfriend
Update test/unit/specs/components/v-modal.spec.js
7ef6f11 
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
@obulat
Copy link
Contributor Author

obulat commented Nov 25, 2022

LGTM! I tested the changes to the focus trap by manually testing the modal behaviour in Storybook.

There's one bit of left over testing code but not blocking so that you're not waiting for a second approval after removing it 👍

I just realized (and later tested) that I need to downgrade vue-tsc to pre-1.0.0 version because it doesn't work correctly with some generic components in Vue 2. The component uses a script-only setup, and manually sets the type of the component. So, the props of that component are inferred incorrectly, at least for Vue 2: vue-tsc expects us to provide ALL of the available props. Downgrading vue-tsc to 0.40.13 fixes it. I'm going to downgrade and we probably should keep it there until we migrate to Vue 3/ Nuxt 3.

But I actually really like moving focus trap code inside the composables, that where we handle all the focus handling anyways :)

Openverse PRs automation moved this from Needs review to Reviewer approved Dec 5, 2022
@obulat obulat merged commit 84b9f81 into main Dec 6, 2022
Openverse PRs automation moved this from Reviewer approved to Merged! Dec 6, 2022
@obulat obulat deleted the update_ts branch December 6, 2022 02:46
github-actions bot pushed a commit that referenced this pull request Dec 6, 2022
@openverse-bot
Clean preview for PR #1993
46b4402
@obulat obulat mentioned this pull request Dec 6, 2022
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@zackkrida zackkrida Awaiting requested review from zackkrida zackkrida is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse PRs
  
Merged!
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to latest TS version
4 participants
@obulat @dhruvkb @sarayourfriend @openverse-bot