This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Replace focus-trap-vue with Vueuse implementation #1758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1758 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
💻 aspect: code
|
Size Change: +983 B (0%) Total Size: 769 kB
ℹ️ View Unchanged
|
|
I'm going to close this issue because there's a type mismatch in the render function: |
obulat
deleted the
fix/replace_focus-trap-vue_with_vueuse_implementation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1752 by @ramadanomar
Description
This PR copies VueUse integrations/useFocusTrap/component implementation to use the latest version of the upstream dependency,
focus-trap.It is clear that
focus-trap-vueis not going to update the Vue-2 branch to add the fix for the linked issue. I wanted to use theuseFocusTrapcomponent from VueUse at first, but I couldn't solve the Nuxt 2 import issue, so I vendored in the UseFocusTrap component. VueUse library is using MIT license, so it should be OK. Hopefully, after we move on to Vue 3, we can use the VueUse library instead of vendoring in the implementation.Testing Instructions
Run the app with
pnpm dev, and on mobile screen, open the menu and filters modals. There should be no errors/warnings regarding the initial focus node in the console, and the focus should be handled correctly. When opening the modal, the first tabbable element should be focused. When you close the modal, you should be able to tab away from the modal trigger.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin