Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove list of keyboard shortcuts from FAQ page #61591

Merged
merged 1 commit into from May 12, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented May 12, 2024

Closes #60627

What?

This PR completely removes the shortcut list from the FAQ documentation page.

Why?

The current shortcut list is manually maintained, so updates to this page may be overlooked and may become out of date in the future. In order to provide a complete and accurate list, it should be sufficient to include the means to access the shortcut modal.

How?

Since the method to access the shortcut modal was already described, I simply deleted only the shortcut list.

Testing Instructions

Check out the shortcuts section of the new FAQ page:

https://github.com/WordPress/gutenberg/blob/docs/remove-faq-shortcut-list/docs/getting-started/faq.md#are-there-keyboard-shortcuts-for-gutenberg

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label May 12, 2024
@t-hamano t-hamano self-assigned this May 12, 2024
@t-hamano t-hamano marked this pull request as ready for review May 12, 2024 05:00
Copy link

github-actions bot commented May 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano requested a review from afercia May 12, 2024 05:00
Copy link
Contributor

@juanmaguitar juanmaguitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 2df566c into trunk May 12, 2024
73 checks passed
@t-hamano t-hamano deleted the docs/remove-faq-shortcut-list branch May 12, 2024 16:03
@github-actions github-actions bot added this to the Gutenberg 18.4 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: List of keyboard shortcuts is out of date
2 participants