Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert data-controls test to TypeScript #61581

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jpstevens
Copy link
Contributor

What?

This PR converts the tests for the data-controls package to TypeScript.

Why?

Ensures package is fully type checked.

How?

  • converted files to .ts
  • cast dummy requests in tests to APIFetchOptions
  • explicitly cast mocked triggerFetch to jest.Mock

Testing Instructions

npm run test:unit -- packages/data-controls tests pass
npm run build:package-types returns a zero exit code

@jpstevens jpstevens requested a review from nerrad as a code owner May 10, 2024 16:05
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jpstevens <jpstevens@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Package] Data Controls /packages/data-controls labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Data Controls /packages/data-controls [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants