Fix double scrollbars in site editor with zoom out view enabled #61548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +72 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
mikachan
reviewed
May 10, 2024
ntsekouras
force-pushed
the
fix-double-scrollbar-zoom-out-view
branch
from
458c8ac
to
05c2233
Compare
mikachan
approved these changes
May 10, 2024
ntsekouras
changed the title
|
this fixes the scrollbars issue but now the issue is that although the content is scrollable I don't see the scrollbars even thought I have "always show scrollbars" option enabled in my OS settings. I assume this can be seen as an issue by some folks (not knowing that something is scrollable) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Maybe fixes: #61093
I'm not sure if it's the same double scrollbar issue mentioned in the issue, but at some cases depending on the viewport width you can have double scrollbar in site editor when having enabled the zoom out view.
Testing Instructions
I can't reproduce this reliably, but here are some instructions:
Screenshots before