Focusing a ref inside tabs needs to wait, why? #61164
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
draganescu
changed the title
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
Just as the nature of React, I don't think we can assume that everything in a given subtree will be mounted synchronously, especially when it involves components that were authored by other people. I think the generic strategy still applies here, where you listen for the mount of a subtree that you do control (sandbox example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moving the search control inside the tab makes the ref be set after the parent component of the tab is mounted. It shouldn't be the case, but it appears that tabs render last.
Why?
We tried in #61108 to move the search control into the inserter tabs and keep the search control auto focus behavior. In the mean time this route is not what makes most sense, but the problem still remains:
requestAnimationFrame?If a component steps out of normal rendering timing via timeouts, effects or other async stuff maybe emiting a ready event when it’s all done is needed?
In the screenshot below the search control should be focused, like it is on trunk.