Block editor: remove CSS appender hiding #61142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Apr 26, 2024
| return { | ||
| order: _order, | ||
| selectedBlocks: getSelectedBlockClientIds(), | ||
| visibleBlocks: __unstableGetVisibleBlocks(), | ||
| shouldRenderAppender: | ||
| hasAppender && | ||
| shouldShowAppender && | ||
| __unstableGetEditorMode() !== 'zoom-out' && | ||
| ( hasCustomAppender | ||
| ? ! getTemplateLock( rootClientId ) && | ||
| getBlockEditingMode( rootClientId ) !== 'disabled' |
There was a problem hiding this comment.
This special condition for the custom appender is also very strange. If a template is locked or editing is disabled, default appenders should also be removed?
There was a problem hiding this comment.
This uses rootClientId so I wonder if we wanted to avoid a situation where blocks could be added if the parent was locked. Maybe @draganescu knows more.
|
Size Change: -107 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0fd4671. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8846615624
|
|
Going to close this for now. We seem to rely on always rendering the appender for blocks like navigation and social icons. In these cases it seems we also want to show the appender when an inner block is selected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
All appenders should be hidden unless the (containing) block is selected, or the block is empty. Currently our logic for normal appenders and custom appenders has diverged, probably not by intention. This also allows us to remove some hiding done by CSS.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast