Remove the lock icon in list views for content only blocks #61012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
|
Size Change: +485 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
update/content-only-lock-icon
branch
from
7789e0e
to
2a85977
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
One thing that stands out in the screenshot is that there's still 'Paste Styles' (which means updating styles and so editing something that's not content) and 'Edit as HTML' (also allows for changing things that aren't content) for content locked blocks. I'm guessing those things shouldn't be present. It would leave just 'Copy' and 'Copy styles' in the menu, which makes sense to me. Would be good to hear other people's thoughts. |
|
I think most of those menu items are a bit confusing, and not very practical given the context. How do you feel about a different menu with help text and a pathway to edit the source document like the mockup in #60834 (comment)? |
Yep, that's mentioned in the PR description that I would work on that in a separate follow-up PR.
If we decide none of the actions in the menu are helpful we can remove them. |
|
Ah, sorry for missing that. Perhaps it's better to hide the ellipsis menu for now? |
This was referenced Apr 26, 2024
|
No worries! I opened a draft PR #61127 to explore the design there. I can continue working on hiding the options dropdown here later so that we have different options. |
Just updated this branch to hide the menu. |
|
Flaky tests detected in 3baf1f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8844137534
|
jameskoster
approved these changes
Apr 26, 2024
talldan
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
LGTM.
I noticed that the thumbnail images and lock icons don't look perfectly positioned, particularly when the block options menu isn't present:
Feels to me like things could line up a little more nicely across rows.
It's an issue in trunk as well, so I don't think it has to be fixed here, and also your follow up PR might reduce the possibility of this happening?
|
Closed by #61127. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #60834. Part of #59819.
Remove the lock icon in list views for content only blocks.
This PR also restore the more menu in the list view as I think there are still some actions useful for content only blocks:1. Copy2. Copy styles3. Paste styles4. Edit as HTMLWe can decide separately if any of these aren't needed or anything else should be added to the list though, as well as the more menu in the block toolbar.The description design exploration shown in #60834 (comment) can be implemented as a follow-up of this PR. (PR: #61127)
Why?
See #60834. The lock icon normally indicates non-editable status, which is not true for content only blocks. This PR removes the lock icon.
How?
Add
isContentOnlycheck in multiple placesTesting Instructions
Screenshots or screencast
Before:
After:
