List View: Expand state if a block is dragged to within a collapsed block in the editor canvas #56493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock in the editor canvas
andrewserong
added
[Feature] Drag and Drop
andrewserong
added
[Type] Bug
|
Size Change: -10 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
andrewserong
commented
Nov 24, 2023
Comment on lines
-30
to
-35
| const parentClientIds = | ||
| Array.isArray( selectedBlockParentClientIds ) && | ||
| selectedBlockParentClientIds.length | ||
| ? selectedBlockParentClientIds | ||
| : null; | ||
|
|
There was a problem hiding this comment.
This has been removed so that we can use selectedBlockParentClientIds in the useEffect dependency array — in theory at least, selectedBlockParentClientIds should only be a new array when there really has been a change and we wish to perform an update, since it gets returned by the useSelect instead of being instantiated on each render.
Although, now that I say that, parentClientIds was probably already a reference to that array, so maybe this change wasn't needed 🤔
In any case, I think it's a little neater without parentClientIds, but happy to revert if folks prefer.
There was a problem hiding this comment.
If selectedBlockParentClientIds?.length does the same job, LGTM to remove it :)
ramonjd
approved these changes
Nov 24, 2023
|
Thanks for reviewing! 🙇 |
andrewserong
deleted the
fix/expand-collapsed-groups-when-dragging-a-block-to-a-collapsed-block
branch
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #49563 and #33683. Also, partially related to #33684.
In the list view, when a block is dragged to a different part of the document (i.e. when dragged to a child of a collapsed block) ensure that the tree is expanded for the selected block in its new position.
Why?
This resolves an issue where if you drag a block with the list view open, it's possible for the dragged block to no longer be visible in the list view, when you drag to another part of the document that is collapsed.
How?
If the selected block's parents has changed, then update the expanded state for the block's parents.
Testing Instructions
useEffectcalled too frequently, or just when expected?Testing Instructions for Keyboard
Screenshots or screencast
Before
2023-11-24.15.56.58.mp4
After
2023-11-24.15.57.30.mp4