Iframe: Bubble events from html element instead of body element to fix drag chip positioning #56099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x drag chip positioning
andrewserong
added
[Type] Bug
andrewserong
requested review from
youknowriad,
apeatling,
ramonjd and
tellthemachines
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Update: this should also fix the same issue with the drag chip getting stuck when dragging over the bottom part of a template in the site editor that is shorter than the height of the viewport. (The following screenshot shows where the
|
youknowriad
approved these changes
Nov 14, 2023
ramonjd
approved these changes
Nov 14, 2023
|
Thanks for the quick reviews, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #33683 and #32438, unblocks #56070
Update the
Iframecomponent's event bubbling to be attached to thehtmlelement instead of thebodyelement, to ensure that drag events are correctly bubbled even if the body element does not completely fill up aniframe. A good example is in the post title wrapper in the post editor.Why?
Currently the drag chip position gets "stuck" over the top area of the editor canvas when it is iframed.
This is because in the post editor, the post title wrapper uses a top margin. As it is the first "real" element within the body of the iframe, due to margin collapse, the top margin is applied to the body element so the
bodydoesn't sit flush at the top of the iframe. As a result, the event bubbling of the iframe does not fire in the top area of the iframe, as there is nobodyelement there to capture and then bubble events.Here is a screenshot of how the
bodyelement does not sit flush to the top within the iframe:How?
The solution is to attach the event bubbling to the
htmlelement instead of thebodyelement, as thehtmlelement will always fill the entirety of the iframe.While we could address the margin issue with the
bodyelement for the case of the post editor, I think a safer solution is to always bubble from thehtmlelement.Testing Instructions
Screenshots or screencast
Before
2023-11-14.15.54.58.mp4
After
2023-11-14.16.18.49.mp4