Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Fix positioning of gradient palette popovers on mobile #50233

Merged
merged 1 commit into from
May 4, 2023
Merged

Global Styles: Fix positioning of gradient palette popovers on mobile #50233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/edit-site/src/components/global-styles/gradients-palette-panel.js
View file
Open in desktop
@@ -1,6 +1,7 @@
/**
* WordPress dependencies
*/
import { useViewportMatch } from '@wordpress/compose';
import {
__experimentalVStack as VStack,
__experimentalPaletteEdit as PaletteEdit,
Expand All @@ -17,6 +18,7 @@ import Subtitle from './subtitle';
import { unlock } from '../../private-apis';

const { useGlobalSetting } = unlock( blockEditorPrivateApis );
const mobilePopoverProps = { placement: 'bottom-start', offset: 8 };

const noop = () => {};

Expand Down Expand Up @@ -63,6 +65,9 @@ export default function GradientPalettePanel( { name } ) {
...( defaultDuotone && defaultDuotoneEnabled ? defaultDuotone : [] ),
];

const isMobileViewport = useViewportMatch( 'small', '<' );
const popoverProps = isMobileViewport ? mobilePopoverProps : undefined;

return (
<VStack
className="edit-site-global-styles-gradient-palette-panel"
Expand All @@ -76,6 +81,7 @@ export default function GradientPalettePanel( { name } ) {
onChange={ setThemeGradients }
paletteLabel={ __( 'Theme' ) }
paletteLabelHeadingLevel={ 3 }
popoverProps={ popoverProps }
/>
) }
{ !! defaultGradients &&
Expand All @@ -88,6 +94,7 @@ export default function GradientPalettePanel( { name } ) {
onChange={ setDefaultGradients }
paletteLabel={ __( 'Default' ) }
paletteLabelLevel={ 3 }
popoverProps={ popoverProps }
/>
) }
<PaletteEdit
Expand All @@ -99,6 +106,7 @@ export default function GradientPalettePanel( { name } ) {
'Custom gradients are empty! Add some gradients to create your own palette.'
) }
slugPrefix="custom-"
popoverProps={ popoverProps }
/>
{ !! duotonePalette && !! duotonePalette.length && (
<div>
Expand Down