Global styles: update __experimentalGetCurrentGlobalStylesId to return full global styles object #49976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the data from the endpoint and only returning the id. This change updates __experimentalGetCurrentGlobalStylesId to return the entire global style object instead of just the ID so we can access further global styles properties.
3 tasks
ramonjd
added
[Type] Feature
|
Size Change: +14 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6a7e651. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4761532480
|
|
Hey there! in several places we do this already: Any reason why this is not good enough for your own use-cases? Unless I'm missing something, the changes in this PR seem to duplicate an entity record in two places in the store? |
Absolutely not, unless you're talking about my complete inability to test properly before I throw a PR up 😵💫 I was just pulling apart #49912 and this PR came out the other end. I'll close. Thank you @youknowriad !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
What?
This change updates
__experimentalGetCurrentGlobalStylesIdand associated store methods to return the entire global style object instead of just the ID so we can access further global styles properties.👋 Question: I though it was okay to change this method because it was experimental. Do folks see any backwards compatibility issues?
Also, would it be better to migrate the new function to the private/unlock system?
Why?
The intention is to add properties to the global styles response object, for example, an entry in
_linksthat contains a revisions URL.See:
How?
Tweaking the methods so that they handle the entire global styles custom post response rather than just the ID.
The
__experimentalGetCurrentGlobalStylesIdresolver was fetching all the data from the endpoint and only returning the id.Testing Instructions
Using this branch, fire up the site editor and run the following command in your console:
Ensure that the object for the current theme's global styles custom post is returned:
Furthermore: