Update the framer motion dependency to the latest version #49822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
approved these changes
Apr 14, 2023
|
Looks like the package upgrade didn't go as expected. Let me check what happened here. |
|
Size Change: +1.05 kB (0%) Total Size: 1.37 MB
鈩癸笍 View Unchanged
|
youknowriad
force-pushed
the
update/framer-motion
branch
from
298e4b6
to
0bb9152
Compare
mtias
requested changes
Apr 14, 2023
mtias
approved these changes
Apr 14, 2023
|
Looks like there's still some JS unit test failures due to the update in the Popover component. Any idea @ciampo |
|
It was the |
youknowriad
commented
Apr 14, 2023
| @@ -5,7 +5,7 @@ exports[`URLPopover matches the snapshot in its default state 1`] = ` | |||
| <span> | |||
| <div | |||
| class="components-popover block-editor-url-popover is-positioned" | |||
| style="position: absolute; top: 0px; left: 0px; transform: none;" | |||
| style="position: absolute; top: 0px; left: 0px; transform: translateZ(0);" | |||
There was a problem hiding this comment.
I'm guessing this is an internal implementation details to framer motion animations change. Maybe perf related
|
Thanks @jsnajdr |
Relevant conversation for more context #46227 (comment) |
ciampo
reviewed
Apr 14, 2023
|
It looks something in this PR broke the e2e test, in my debugging it seems that when clicking "browse all templates" in the site editor title popover (the one you trigger from the header of the editor), the navigation happens properly but the popover lingers in the DOM for some reason even though it should unmount entirely since it's not rendered anymore. |
|
I'm also not able to reproduce the popover lingering manually, I only see it in the tests debug trace. |
|
Is that e2e test the remaining blocker? |
|
@mtias yes |
youknowriad
force-pushed
the
update/framer-motion
branch
from
92ebc00
to
36dd22e
Compare
youknowriad
force-pushed
the
update/framer-motion
branch
from
36dd22e
to
96c5353
Compare
bph
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
馃 Generated by Copilot at 298e4b6
Updated
framer-motiondependency inpackages/components/package.jsonto fix animation issues and use new features. Part of a larger dependency update and bug fix pull request.馃 Generated by Copilot at 298e4b6
WHY
Latest is the greatest
HOW
馃 Generated by Copilot at 298e4b6
framer-motiondependency to fix animation issues and use latest features (link)