Add a UI to allow saving patterns #49607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +53 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eb29d2b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4636885831
|
aristath
force-pushed
the
YCD/patterns-ui
branch
5 times, most recently
from
e27e34a
to
17e2e0f
Compare
|
I was trying to decipher what this PR is all about, and then I found this comment from @carolinan in #33094:
This is very interesting when it eventually combines with the planned work on This is going to be interesting to see how the concept of Reusable blocks morphs into Synced Patterns managed by sites, making them capable of fulfilling many of the needs that lead today creating custom blocks. |
Yeah, it's basically trying to allow users to create and save patterns - just like they do for reusable blocks... |
gziolo
added
[Type] Technical Prototype
|
I know this PR is not ready for testing yet, but I couldn't help myself 😅 Excellent work so far. I'm looking forward to seeing how this evolves! |
|
Awesome exploration! The main implementation aspect that I'd like to revise is that of using a separate post type. This is a great opportunity to coalesce on how we are storing user reusable content (see #34352 and #41717). So I'd love to see if we can incorporate into the exploration the idea of using
Sync status can either be a meta value of the post type or an aspect of the insertion (full sync and partial sync would exist as |
aristath
changed the title
This reverts commit 355b4f3.
|
should this be closed as it was implemented here: #51144? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props @mykola @janw-me @hdvos @rolf-yoast @enricobattocchi @aristath @carolinan @SergeyBiryukov @mhkuu @afercia during a Yoast contributor day on April 5, 2023
What?
This PR adds a UI to allow users to save and edit patterns in the editor.
The UI is identical to that of reusable-blocks.
Why?
Right now patterns can only be created programmatically, and there have been numerous requests to allow users to create and edit their own patterns.
How?
Duplicating the functionality of reusable blocks.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast