Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position Panel: Open by default if a position type is set #49151

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Position Panel: Open by default if a position type is set #49151

merged 6 commits into from
Mar 21, 2023

Commits on Mar 17, 2023

  1. Position Panel: Open by default is a position type is set

    @andrewserong
    andrewserong committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    7cc5812 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Remove prop drilling clientId, grab all selected client ids and use f… 

    …irst id for attributes check
    @andrewserong
    andrewserong committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    32289bb View commit details
    Browse the repository at this point in the history

  2. Iterate over block selection and open by default if at least one bloc… 

    …k has a position type set.

Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
    @andrewserong @aaronrobertshaw
    andrewserong and aaronrobertshaw committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    a56b54f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Add useState and an effect so that we only perform the calculation once

    @andrewserong
    andrewserong committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    ffc76f7 View commit details
    Browse the repository at this point in the history

  2. Try to reduce flicker

    @andrewserong
    andrewserong committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    4da0531 View commit details
    Browse the repository at this point in the history

  3. Update to useLayoutEffect

    @andrewserong
    andrewserong committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    f998b3b View commit details
    Browse the repository at this point in the history