Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List View: add an indicator of when a position type is set for a block #49122

Merged
merged 10 commits into from
Jun 19, 2023
Merged

List View: add an indicator of when a position type is set for a block #49122

merged 10 commits into from
Jun 19, 2023

Commits on Jun 1, 2023

  1. List View: add a position label when a position type is set for a block

    @andrewserong
    andrewserong committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    55e6d43 View commit details
    Browse the repository at this point in the history

  2. Move get label function to the useBlockDisplayInformation file

    @andrewserong
    andrewserong committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    4340805 View commit details
    Browse the repository at this point in the history

  3. Try using icon over the block icon instead of a text label to indicat… 

    …e sticky status
    @andrewserong
    andrewserong committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    3f31f9b View commit details
    Browse the repository at this point in the history

  4. Try more subtle icon / styling idea, and add in a tooltip

    @andrewserong
    andrewserong committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    d2e3aa7 View commit details
    Browse the repository at this point in the history

  5. Try provided svg icons

    @andrewserong
    andrewserong committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    f854ccd View commit details
    Browse the repository at this point in the history

  6. Don't change color when hovered

    @andrewserong
    andrewserong committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    1cd0e32 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Try separate sticky icon instead

    @andrewserong
    andrewserong committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b2b3997 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Add pinSmall icon

    @andrewserong
    andrewserong committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    23bed70 View commit details
    Browse the repository at this point in the history

  2. Minify pinSmall

    @jameskoster
    jameskoster committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    f6b6f14 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Add additional optional chaining because attributes can technically b… 

    …e null
    @andrewserong
    andrewserong committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    aecbf4f View commit details
    Browse the repository at this point in the history