Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List View: Allow Escape key to deselect blocks if blocks are selected #48708

Merged
merged 11 commits into from
Sep 5, 2023
Merged

List View: Allow Escape key to deselect blocks if blocks are selected #48708

merged 11 commits into from
Sep 5, 2023

Commits on Sep 1, 2023

  1. List View: Allow Escape key to deselect blocks if blocks are selected

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    7a77ce2 View commit details
    Browse the repository at this point in the history

  2. Add comment, check which tab is active in post editor

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    eb25cf2 View commit details
    Browse the repository at this point in the history

  3. Add speak call, use clearSelectedBlock action

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    37625e8 View commit details
    Browse the repository at this point in the history

  4. Add behaviour to widgets editor, too

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2589db5 View commit details
    Browse the repository at this point in the history

  5. Move clear selection handling down to the List View container so that… 

    … if focus is on the close or tab buttons, Escape closes the list view instead of clearing
    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    afa979a View commit details
    Browse the repository at this point in the history

  6. Try selecting the last selected block when closing the list view if n… 

    …o blocks are selected
    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    01bb07b View commit details
    Browse the repository at this point in the history

  7. Revert changes

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    2c18117 View commit details
    Browse the repository at this point in the history

  8. Try clearing the selection from within the list view

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b93392d View commit details
    Browse the repository at this point in the history

  9. Revert change

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    4d3cb50 View commit details
    Browse the repository at this point in the history

  10. Add test

    @andrewserong
    andrewserong committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    068d08c View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Fix issue where announcement for deselection was not occurring

    @andrewserong
    andrewserong committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    0397d33 View commit details
    Browse the repository at this point in the history