Make the template customized info accessible. #48159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Focus] Accessibility (a11y)
|
Size Change: -66 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7a7af12. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4232478302
|
afercia
force-pushed
the
fix/customized-template-info-accessibility
branch
from
e4a3aa6
to
b76c59a
Compare
afercia
force-pushed
the
fix/customized-template-info-accessibility
branch
from
b76c59a
to
7a7af12
Compare
|
Rebased on top of latest trunk. |
annezazu
added
the
Backport to WP Beta/RC
|
Adding the backport label for consideration and adding to the 6.2 board. Feels like a solid improvement to get into 6.2 @Mamaduka @ntsekouras. |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 28, 2023
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 73110bf |
ntsekouras
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42557
What?
In the templates/parts list, customized templates/parts show a blue 'dot'. Hovering the dot shows a tooltip with text 'This template/part has been customized'. The blue dot is only viusal information, there's no other semantic information. The tooltip appears only on hover and it's not accessible for keyboard users.
This PR removes the dot and tooltip in favor of visible text, as agreed on #42557 (comment)
Why?
The current 'customized info' is not accessible.
How?
Makes the info use visible text.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: