Handle block metadata attribute and related experimental APIs #47791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Package] Block editor
getdave
commented
Feb 6, 2023
14 tasks
|
Size Change: +14 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Feb 6, 2023
|
@ntsekouras Sorry if it seems obvious but what do you see as the next steps here? |
ntsekouras
force-pushed
the
try/handle-experimental-metadata
branch
from
3f9e6cc
to
db02a6a
Compare
ntsekouras
added
the
Backport to WP Beta/RC
|
This PR's |
ntsekouras
force-pushed
the
try/handle-experimental-metadata
branch
from
3435c8f
to
774d503
Compare
|
Flaky tests detected in 774d503. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4144068864
|
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: a6bc65a |
ntsekouras
added a commit
that referenced
this pull request
Feb 13, 2023
* Move PHP attribute registration to experiments dir * Limit __experimentalMetadata to Core blocks * fix check --------- Co-authored-by: ntsekouras <ntsekouras@outlook.com>
ntsekouras
removed
the
Backport to WP Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Attempts to avoid releasing
__experimentalMetadataand associated blockmetadataattribute in WP 6.2.Why?
Audit of experimental APIs for 6.2 flagged it.
After discussing with @ntsekouras (away from Github) we settled on avoiding the APIs being released at all outside of the Plugin.
How?
compat/6.1and into thelib/experiments/dir.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast