Export off canvas editor via experiments package #47465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ellatrix,
tellthemachines and
ajitbohra
as code owners
draganescu
added
[Type] Code Quality
|
Size Change: +831 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
try/experimental-wrapped-offcanvas
branch
from
1597418
to
256576b
Compare
scruffian
reviewed
Jan 26, 2023
|
Flaky tests detected in 4798574. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4024506080
|
talldan
reviewed
Jan 27, 2023
packages/edit-site/src/components/sidebar-edit-mode/navigation-menu-sidebar/navigation-menu.js
Outdated
Show resolved
Hide resolved
draganescu
force-pushed
the
try/experimental-wrapped-offcanvas
branch
from
256576b
to
7f1bfeb
Compare
draganescu
force-pushed
the
try/experimental-wrapped-offcanvas
branch
from
15a4894
to
cfb1ce8
Compare
|
I have merged this with some failing mobile unit tests and react native tests. I decided on the fact that the changeset is really limited and the failures were most likely unrelated. |
Hey @draganescu, seems that these changes have introduced an actual failure in the mobile unit tests. Even though the failures look unrelated to the changes, I think it would have been great to address them before merging. Especially as now the mobile unit tests will fail in |
|
Hi there 👋 This PR really directly caused the mobile tests failures. Because the The first failure is After adding a workaround for this, I start getting another failure: I don't immediately know how to fix this one. Seems we'll need something like |
scruffian
added a commit
that referenced
this pull request
Jan 27, 2023
This reverts commit c0abd3f.
|
I created a revert here: #47512. Please can someone review? |
|
Thanks @scruffian. 🙇🏻 I opened #47513 for consideration as well. It includes a fix for the failing mobile unit tests, implementing the suggestion by @jsnajdr in #47465 (comment). I agree with @jsnajdr that a separate experiments file is likely appropriate to avoid the errors caused from importing the Do you think it makes sense to review and merge #47513 instead? |
If the tests pass then yes |
|
Howdy friends! 😱 ups! I am sorry for the mess @fluiddot and the entire mobile team - I convinced myself too easily it's all unrelated, a symptom of low faith in how well the CI works. Thank you for fixing this @dcalhoun and @scruffian - I am glad y'all found a solution and not reverted the experimental export. Again, sorry for the breakage I caused 😊 |
youknowriad
reviewed
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Advances #47039 to allow the navigation block to use the new functionality while figuring out the best implementation details later.
Why?
Because the new functionality in the navigation block is basically a list view with a few additions but the additions don't have a clear path yet into the list view. Ideally the off canvas component will disappear.
How?
Using the new experiments package found landed by #46131 we hide this component from the block editor package but are still able to use it in the block library package.
Testing Instructions
\Testing Instructions for Keyboard
Screenshots or screencast