Revert "Block Settings/Support: Use Tag Processor to inject class name on wrapper." #47350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on wrapper." This reverts commit b187df8.
9 tasks
Mamaduka
approved these changes
Jan 23, 2023
ockham
deleted the
revert/update/block-support-settings-use-tag-processor
branch
juanmaguitar
added
the
[Type] Regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #46625.
Why?
See #47349.
How?
It's a simple revert.
Testing Instructions
Quoting #46625:
#46625 was a refactor to replace a hand-crafted RegEx with use of the
WP_HTML_Tag_Processor. Thus, it shouldn't have introduced any semantic changes; it might've fixed some edge cases (see its PR desc). However, since its main goal wasn't to be a bugfix, reverting it should be okay, since we're simply returning to the previous behavior, which should also be fine.