Element: export new React 18 APIs #46610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -3.33 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Dec 16, 2022
| @@ -43,6 +44,20 @@ export { render }; | |||
| */ | |||
There was a problem hiding this comment.
Should we add a @deprecated for render() and hydrate() now that they are deprecated in React 18?
There was a problem hiding this comment.
I think we if add @deprecated, we need to also add a real deprecated function call, so let's leave it for later when we migrate all of our usage.
There was a problem hiding this comment.
Sure. Maybe adding a comment would suffice then.
| @@ -198,6 +198,14 @@ _Returns_ | |||
|
|
|||
| - `Object`: Ref object. | |||
|
|
|||
| ### createRoot | |||
|
|
|||
| Creates a new React root for the target DOM node. | |||
There was a problem hiding this comment.
An ideal place to mention that these are deprecated now in React 18.
| /** | ||
| * @see https://reactjs.org/docs/hooks-reference.html#usesyncexternalstore | ||
| */ | ||
| export { useSyncExternalStore }; |
There was a problem hiding this comment.
Does it make sense to add the rest of the new hooks (useId, useTransition, useDeferredValue, useInsertionEffect)? I can immediately see opportunities for almost all of them.
Note that if we add useTransition we might want to expose startTransition as well.
There was a problem hiding this comment.
Good idea, pushed a commit that exports them all.
| * @see https://reactjs.org/docs/react-dom-client.html#hydrateroot | ||
| */ | ||
| export { hydrateRoot }; | ||
|
|
There was a problem hiding this comment.
Suspense has already been exposed for some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts exporting new React 18 API from
@wordpress/element. A standalone PR we'll later use in #46467 (createRootand concurrent mode) and in #46606 (useSelectwithuseSyncExternalStore).