Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SpacingSizesControl ARIA from region to group #46530

Merged
merged 3 commits into from Dec 15, 2022
Merged

Change SpacingSizesControl ARIA from region to group #46530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fb5997
Change SpacingSizesControl ARIA from region to group
Mamaduka Dec 14, 2022
f0bb5da
Add changelong entry
Mamaduka Dec 14, 2022
b1ed7d2
Use correct changelog file
Mamaduka Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/block-editor/CHANGELOG.md
View file
Open in desktop
Expand Up @@ -8,7 +8,11 @@

### Enhancements

- `URLInput`: the `renderSuggestions` callback prop now receives `currentInputValue` as a new parameter ([45806](https://github.com/WordPress/gutenberg/pull/45806)).
- `URLInput`: the `renderSuggestions` callback prop now receives `currentInputValue` as a new parameter ([45806](https://github.com/WordPress/gutenberg/pull/45806)).

### Bug Fix

- `SpacingSizesControl`: Change ARIA role from `region` to `group` to avoid unwanted ARIA landmark regions ([#46530](https://github.com/WordPress/gutenberg/pull/46530)).

## 10.5.0 (2022-11-16)

Expand Down
1 change: 0 additions & 1 deletion packages/block-editor/src/components/spacing-sizes-control/index.js
View file
Open in desktop
Expand Up @@ -78,7 +78,6 @@ export default function SpacingSizesControl( {

return (
<fieldset
role="region"
className={ classnames( 'component-spacing-sizes-control', {
'is-unlinked': ! isLinked,
} ) }
Expand Down