Block editor: hide fixed contextual toolbar #46298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +50 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
I didn't review/test yet but I guess this might be an issue on mobile/fixed toolbar mode where we have a dedicated area for the toolbar and if we show/hide it conditionally it causes jumps. |
ramonjd
changed the title
I tested it and it wasn't too annoying, but I have high tolerance for bad UX so I'll lean on the opinion of others 😄 Another option is to keep it visible for narrow widths (?) |
|
Let's get some designers opinion on this. @jasmussen @jameskoster |
|
Maybe in the case of "fixed toolbar" and no selected block we should show a small placeholder/message when all blocks are unselected. |
|
The jumping is quite disorienting, I agree it would be good to avoid that. Not entirely sure about showing a message though, it feels like a bit of a crutch. Before thinking more about this, might it be worth considering the updates we had in mind for this feature over in #40450 (comment) ? I believe the solution presented there would solve this issue. |
|
Thanks folks. What do you think about targeting first (if it's possible) the toolbar in the site editor view mode? It does look a bit janky in my opinion:
|
|
@ramonjd yes, that makes sense, we should definitely remove it from there. |
|
I would agree with jay, the jumping is a bit disorienting, and it would be good to have a small interim fix for the browse mode. #40450 still feels like the longer term improvement to make, and would address perhaps the remaining pieces. |
…use it creates a large, empty space at the top of the page, taking up room in mobile and showing an empty space in the site editor view mode.
Temporary CSS rule to hide the contextual toolbar in view mode for the site editor
ramonjd
force-pushed
the
update/hide-context-block-toolbar
branch
from
6b77b90
to
01b904e
Compare
|
I've added a temporary CSS fix to hide the contextual tool bar in view mode, and only for the site editor. I couldn't see other opportunities that were not invasive or didn't involve updating other components. If folks can think of a better way, please let me know. |
youknowriad
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41047 (maybe)
What?
A temporary CSS fix to hide the contextual tool bar in view mode, and only for the site editor.
Why?
This is because it creates a large, empty space at the top of the page in the site editor view mode.
How?
Checking for view mode, then displaying "none".
Testing Instructions
Before testing, ensure you have fixed the toolbar using the editor settings accessible via the dots menu.
Open the site editor, check that the contextual toolbar does not show in view mode:
Ensure that no other views are affected, e.g., in edit mode, selecting blocks...