RNMobile: Add an inline comment to clarify usage of 'hard' limit vs. unbounded query #46245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Dec 1, 2022
…allery-hard-limit
SiobhyB
deleted the
rnmobile/update/clarifying-comment-around-gallery-hard-limit
branch
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
ryanwelcher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a very small PR that simply adds an inline comment to explain that unbounded queries aren't currently supported on native (as per wordpress-mobile/gutenberg-mobile#2661), which clarifies the usage of a hard limit in the
gallery/use-get-media.native.jsfile.Why?
This change was made following a suggestion in #46143. The web version of the
gallery/use-get-media.native.jsfile uses an unbound query, and it was thought that the difference between the queries in the native vs. web files may cause confusion. The addition of the inline comment seeks to mitigate any potential confusion.How?
An inline comment has been added alongside the query in question.
Testing Instructions
As this PR only involves the addition of an inline comment to the code, no manual testing is required. It's only necessary to review the comment for clarity.