Block Editor: Improve act() usage in UrlPopover tests
#46230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
youknowriad,
jsnajdr,
flootr and
ntsekouras
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
As recognized, there are some flaws with this approach, it's not reliable enough to check if a popover is positioned the way we do. I'll reconsider the approach in another PR. |
jsnajdr
reviewed
Dec 2, 2022
| expect( | ||
| getWrappingPopoverElement( screen.getByText( 'Editor' ) ) | ||
| ).toBePositionedPopover() | ||
| ); |
There was a problem hiding this comment.
One interesting thing here is that the test doesn't pass an anchor prop to the URLPopover, so there should be no positioning.
However, the Popover component has a fallback for that case, where it will use the popover element's parent as anchor. @ciampo Are there cases where the fallback is actually used and does something useful? I can imagine using a popover inside a paragraph for example:
<p>Lorem ipsum <span>dolor<Popover>latin for pain</Popover></span> sit amet<p>and the it will be permanently attached to the span with word "dolor"? Is that what the fallback element is for?
If we didn't do any fallback for anchor, then it would remain null and floating-ui wouldn't do any positioning at all. The popover would have a position: absolute style and that's all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the
act()usage inUrlPopoverto make the tests more precise and expressive.Why?
As part of the React 18 upgrade in #45235, we added a bunch of
act()calls that could be improved and made more specific.How?
Instead of going with
await act( () => Promise.resolve() ), we change the test to wait for the popover to be positioned before continuing.Testing Instructions
Verify tests still pass:
npm run test:unit packages/block-editor/src/components/url-popover/test/index.jsTesting Instructions for Keyboard
None
Screenshots or screencast
None