Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Editor: Wait for popover positioning in MediaReplaceFlow tests #45863

Merged
merged 10 commits into from
Nov 21, 2022
Merged

Block Editor: Wait for popover positioning in MediaReplaceFlow tests #45863

merged 10 commits into from
Nov 21, 2022

Commits on Nov 17, 2022

  1. Block Editor: Wait for popover positioning in MediaReplaceFlow tests

    @tyxla
    tyxla committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    001d6b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Remove an extra backtick

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    e035d52 View commit details
    Browse the repository at this point in the history

  2. Use Element.closest() to locate closest popover

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    1f7ee28 View commit details
    Browse the repository at this point in the history

  3. Fix comment

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    99069f9 View commit details
    Browse the repository at this point in the history

  4. Remove an excess assertion

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    1e65537 View commit details
    Browse the repository at this point in the history

  5. Reorder assertions

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    8032ab0 View commit details
    Browse the repository at this point in the history

  6. Introduce a less-specific way to assert positioning

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    e59733d View commit details
    Browse the repository at this point in the history

  7. Use the right element when locating the popover

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    85d318d View commit details
    Browse the repository at this point in the history

  8. Clarify element.style usage

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6c63bc5 View commit details
    Browse the repository at this point in the history

  9. Wait for the menu to get visible

    @tyxla
    tyxla committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    56eef5d View commit details
    Browse the repository at this point in the history