Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLInput: keep the search results label in sync with the results list #45806

Merged
merged 9 commits into from Nov 28, 2022
Merged

URLInput: keep the search results label in sync with the results list #45806

merged 9 commits into from Nov 28, 2022

Commits on Nov 28, 2022

  1. URLInput: reorganize the renderSuggestion condition

    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0cea868 View commit details
    Browse the repository at this point in the history

  2. URLInput: simplify shouldShowInitialSuggestions which always runs wit… 

    …h initial state
    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    17ef92d View commit details
    Browse the repository at this point in the history

  3. URLInput: don't updateSuggestions on change, it's done by cDU lifecycle

    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a7b13b2 View commit details
    Browse the repository at this point in the history

  4. URLInput: cancel suggestionsRequest when updated value means no request

    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4401486 View commit details
    Browse the repository at this point in the history

  5. URLInput: set empty suggestions when updated value means no request

    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    24dd6bb View commit details
    Browse the repository at this point in the history

  6. URLInput: move isUpdatingSuggestions to state

    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    fb63445 View commit details
    Browse the repository at this point in the history

  7. URLInput: put the current input value to state, in sync with search r… 

    …esults
    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3ff9d20 View commit details
    Browse the repository at this point in the history

  8. LinkControl: don't send currentInputValue to URLInput, it already doe… 

    …s it internally
    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3656e40 View commit details
    Browse the repository at this point in the history

  9. URLInput: mention the currentInputValue param for renderSuggestions i… 

    …n block-editor changelog
    @jsnajdr
    jsnajdr committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4459a77 View commit details
    Browse the repository at this point in the history