BlockManagerCategory: Fix styles for indeterminate #45564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: -19 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught when reviewing #45535
What?
Updates BlockManagerCategory so it uses the official
indeterminateprop exposed by CheckboxControl, rather than do its own thing witharia-checked.Why?
To fix the incorrect styling.
Should we fix the underlying CSS so the styling is correct even when a custom
aria-checkedimplementation is used instead of theindeterminateprop? Maybe, but that is higher effort as it involves a base-styles mixin, and I don't have the appetite for that right now. (See also the discussion about decoupling wp-components from base-styles mixins.)Testing Instructions
npm run devScreenshots or screencast