FontSizePicker: fix a buggy unit test #45529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
jsnajdr
force-pushed
the
fix/font-size-picker-test
branch
from
6792b55
to
cbbe226
Compare
jsnajdr
force-pushed
the
fix/font-size-picker-test
branch
from
cbbe226
to
280fccc
Compare
youknowriad
approved these changes
Nov 4, 2022
I didn't track down the exact reason, that would be fairly difficult, but it's plausible that the two bugs I found make the UI fail. There are list items with duplicate keys, so maybe they rerender over each other? Also, some components might not see the updated |
tyxla
reviewed
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an unreliable e2e test that starts failing after React 18 migration (#45235). There are two bugs:
The first one is a typo introduced in #37446 by @youknowriad. If you look at the diff, notice the extra
,character in the font sizes array? That creates a sparse array that skips one index, and when merging such an array into existing one withlodash.merge, the element at the skipped index will have an old value:The result is that the overridden font size list has one item from the old list (namely for "Medium"), that there are items for a "Medium" size that cause a "duplicate React key" warning, and that array indexes in
expect()calls are off by one.The second bug is that the
lodash.mergefunction modifies the settings object by mutating it. AfterupdateSettings, thegetSettingsselector will still return the same object, identity-wise, just mutated. If a component depends on the settings state:it won't be rerendered because the old value is shallowly equal to the new one. Rerendering with the updated font size list must be accidentally triggered by something else. And it seems that in React 18 it's not.