Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluid typography: ensure fontsizes are strings or integers #44847

Merged
merged 4 commits into from Oct 11, 2022
Merged

Fluid typography: ensure fontsizes are strings or integers #44847

merged 4 commits into from Oct 11, 2022

Commits on Oct 11, 2022

  1. Updating PHP doc to describe incoming type of $raw_value (string|int) 

    This PR also harmonizes the JS checks
And review comments from #44807 (review)
These changes have already been backported to Core in WordPress/wordpress-develop#3428
    @ramonjd
    ramonjd committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0c09375 View commit details
    Browse the repository at this point in the history

  2. Update changelog 

    Add extra test for floats
Add i18n domain
    @ramonjd
    ramonjd committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0ab24b5 View commit details
    Browse the repository at this point in the history

  3. Font sizes can be string|int|float 

    Updated tests and JSDoc type
    @ramonjd
    ramonjd committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    95103ae View commit details
    Browse the repository at this point in the history

  4. Expand tests for gutenberg_get_typography_value_and_unit 

    Fix typo in CHANGELOG.md
    @ramonjd
    ramonjd committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    f10d15b View commit details
    Browse the repository at this point in the history