Edit-post: Remove right border when sidebars are closed. #44613
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +62 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Oct 3, 2022
|
Thanks, all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The edit-site package adds or removes the sidebar when it's opened or closed. The edit-post package, however, always has the sidebar in the canvas. This PR adds edit-post specific rules ensures there isn't a border on the right of the canvas when a sidebar is visually closed.
Before, zoom in, notice there's a light gray border to the right of the dark canvas:
After, this border is gone:
Testing Instructions
Please test both edit-post and edit-site, with and without sidebars open. Including plugin sidebars, ideally. When a sidebar is closed, no border should be present. When a sidebar is open, it should be.