Add a few filters to make it possible to change the default navigation icons

[SGr33n]

Added a few filters to make it possible to programmatically change the navigation icons.

At time #43674 there is no chance to change the default navigation icons. The only way to customize them is filtering inside render_block_core/navigation and making a string replacement on $block_content... not really the cleanest way.

So I added a few filters to make it possible.

They are:

• block_core_navigation_render_submenu_icon : The submeu Chevron
• block_core_navigation_render_toggle_button_icon : The first icon option
• block_core_navigation_render_toggle_button_icon_menu : The second icon option
• block_core_navigation_render_toggle_button_more_vertical : The third icon option
• block_core_navigation_render_toggle_button_more_horizontal : The fourth icon option
• block_core_navigation_render_toggle_close_button_icon : The close button (X)

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @SGr33n! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[talldan]

Thanks for picking this up.

The problem with filtering here is that the user could have selected a particular icon in the editor, but then a filter applied by a plugin renders something completely different on the frontend, which results in a very confusing experience.

I think ideally the solution would be a filter that modifies the array of available icons for the user to select.

That may require JS and PHP code though.

[SGr33n]

You're right, or replace filters with making possible to upload custom icons on Gutenberg.

[github-actions]

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Block] Navigation, First-time Contributor.

Read more about Type labels in Gutenberg.

[skorasaurus]

If you're still interested in this; there's active discussion about this at #53510