Image: Display upload error notices using snackbars #43767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
noisysocks,
glendaviesnz and
jasmussen
and removed request for
ajitbohra
Mamaduka
added
[Type] Regression
Mamaduka
commented
Sep 1, 2022
| @@ -374,4 +372,4 @@ export function ImageEdit( { | |||
| ); | |||
| } | |||
|
|
|||
| export default withNotices( ImageEdit ); | |||
There was a problem hiding this comment.
We no longer need this HoC.
|
Size Change: -57 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Beautiful! Instead of a notice that is likely to get cropped or wrap weirdly when #38990 is a thing, we get this handy snackbar that explains and announces what's up:
This is a substantially better experience, and the amount of red in this PR is beautiful. I'd appreciate a code check but this is great.
Thank you for fixing this 🙏
|
Do you think we should update other media blocks to use Snackbar notifications for errors? |
If you mean ensure they don't show up in placeholders, then yes. Placeholders are great, but as patterns and templating opportunities have improved, it's become clear how often the placeholders will be shown in narrow/small contexts, making it all the more necessary that critical information be extracted and shown elsewhere, so it doesn't just get hidden by responsive rules. |
Correct. I will try to update the remaining blocks. |
|
Thanks for fixing this! Agree snackbars are better and |
This was referenced Sep 6, 2022
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A follow-up to #43180 (comment).
PR updates image block
onUploadErrormethod to use snackbar error notices.Why?
The new placeholder state doesn't display Notice UI. Matches behavior of Site Logo and Post Feature Image blocks, which also use alternative placeholder states.
Testing Instructions
touch empty.pngScreenshots or screencast
CleanShot.2022-09-01.at.14.06.21.mp4