Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term Description: Add missing typography supports #43568

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography supports to the Term Description block.

Why?

  • Improves consistency of our design tools across blocks.

How?

Opts into the following missing typography supports.

  • font family
  • font weight
  • font style
  • text transform
  • text decoration
  • letter spacing

Testing Instructions

  1. In the site editor, edit an Archive template.
  2. Add a Term Description block and select it.
  3. Within the Settings sidebar, adjust typography settings and confirm they are reflected in the preview and frontend.
  4. Reset all the block's typography settings.
  5. Navigate to Global Styles > Blocks > Term Description > Typography
  6. Test applying the new typography styles and confirm they're applied in the preview and on the frontend.
  7. Test styling via theme.json

Example theme.json snippet:

			"core/term-description": {
				"typography": {
					"letterSpacing": "2px"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.7.18.26.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs [Block] Term Description Affects the Term Description Block - used for displaying the description of a tag, catergory or othe labels Aug 24, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 24, 2022
@andrewserong andrewserong force-pushed the add/missing-typography-supports-to-term-description branch from eda59bb to 758d812 Compare August 25, 2022 05:00
@andrewserong
Copy link
Contributor

Just given this a rebase to see if it'll get tests passing.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all working nicely for me on an Archive Page in the editor, with adjustments via global styles, and rendered on the site frontend once I add a description to a tag:

image

LGTM! I'll merge this in and update the tracking issue.

@andrewserong andrewserong merged commit ccc584c into trunk Aug 25, 2022
@andrewserong andrewserong deleted the add/missing-typography-supports-to-term-description branch August 25, 2022 06:26
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 25, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Term Description Affects the Term Description Block - used for displaying the description of a tag, catergory or othe [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants