Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Title: Add missing typography supports #43565

Merged
merged 1 commit into from Aug 25, 2022
Merged

Query Title: Add missing typography supports #43565

merged 1 commit into from Aug 25, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography supports to the Query Title block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing text-decoration typography support.

Testing Instructions

  1. In the site editor, edit the Archive template and select the Archive Title block.
  2. Navigate to the Block tab of the Settings sidebar.
  3. Adjust the text-decoration value ensuring it is reflected in both the preview and the frontend.
  4. Clear customizations and test that text-decoration can be applied via theme.json

Example theme.json snippet:

			"core/query-title": {
				"typography": {
					"textDecoration": "line-through"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.7.00.39.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Query Title Affects the Query Title Block [Feature] Typography Font and typography-related issues and PRs labels Aug 24, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 24, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 24, 2022
Open
6 tasks
andrewserong
andrewserong approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working nicely for me, too 👍

@andrewserong andrewserong merged commit 79dcf05 into trunk Aug 25, 2022
@andrewserong andrewserong deleted the add/missing-typography-supports-to-query-title branch August 25, 2022 05:22
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 25, 2022
@andrewserong
Copy link
Contributor

Merged and updated the tracking issue.

@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewserong andrewserong andrewserong approved these changes

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Query Title Affects the Query Title Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aaronrobertshaw @andrewserong @ntsekouras @femkreations