Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Pagination: Add typography support #43552

Merged
merged 1 commit into from Aug 29, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds typography support to the Query Pagination block.

Why?

  • Improves consistency of our design tools across blocks.
  • Adds higher level typography styling for the inner blocks of the Query Pagination block.

How?

  • Opts into all typography supports.
  • Only the font size control will display by default.

Testing Instructions

  1. In the site editor, edit a template with a Query block.
  2. Navigate to Global Styles > Blocks > Query Pagination > Typography and apply typography styles there.
  3. Confirm the Query Pagination block within the preview updates accordingly.
  4. Save and check the styling is correct on the frontend.
  5. Back in the site editor, select the Query Pagination block.
  6. Navigate to the Settings sidebar and the block tab.
  7. Adjust the block's typography settings here and confirm they are reflected in the preview.
  8. Save and check the frontend again.
  9. Clear your customizations.
  10. Test that the block can be styled via theme.json.

Example theme.json snippet:

			"core/query-pagination": {
				"typography": {
					"fontWeight": "100"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.6.07.14.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Feature] Typography Font and typography-related issues and PRs labels Aug 24, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 24, 2022
@andrewserong andrewserong force-pushed the add/typography-support-to-query-pagination branch from 7ca9f31 to 248be88 Compare August 29, 2022 05:21
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing nicely for me:

image

✅ Each control works correctly at the block level
✅ Each control works correctly in global styles and when saved and viewed on the site frontend
✅ Values entered in theme.json at the block level appear to be output correctly

LGTM! ✨

@aaronrobertshaw aaronrobertshaw merged commit ab814ed into trunk Aug 29, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/typography-support-to-query-pagination branch August 29, 2022 22:55
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 29, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants