Latest Comments: Add typography support #43310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
6 tasks
aaronrobertshaw
force-pushed
the
add/typography-support-to-latest-comments
branch
from
afca56b
to
5911a54
Compare
|
Size Change: +229 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
aaronrobertshaw
force-pushed
the
add/typography-support-to-latest-comments
branch
from
5911a54
to
041f4de
Compare
aaronrobertshaw
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Flaky tests detected in 041f4de. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4132314156
|
glendaviesnz
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Tested well for me:
✅ Typography styles applied to the Latest Comments block in Global styles were applied to the block in Post Editor and frontend
✅ Typography settings applied to a Latest Comments block in the Post editor were applied in the editor and frontend
✅ Spacing settings applied to a Latest Comments block were applied to the wp-block-latest-comments outer wrapper in the editor and spacing settings were applied as expected in the frontend
aaronrobertshaw
deleted the
add/typography-support-to-latest-comments
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Adds typography support to the Latest Comments block.
Why?
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-02-09.at.6.23.08.pm.mp4