Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Template: Adopt typography supports #43266

Merged
merged 1 commit into from Aug 18, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adopts all typography supports for the Comment Template block.

Why?

  • Improves consistency of our design tools across blocks.
  • Allows typographic styles to be applied in one go to all the inner comment template blocks.

How?

  • Opts into all typography block supports.
  • Makes the font size control displayed by default to match most common config.

Testing Instructions

  1. Open a post with comments in the editor, add a comments block and select it.
  2. Confirm font size control is displayed by default. Then test various typography settings.
  3. Save and confirm styling on the frontend.
  4. Switch to the site editor and navigate to Global Styles > Blocks > Comment Template > Typography and apply typography styles there.
  5. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-16.at.8.53.45.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Comment Template Affects the Comment Template Block [Feature] Typography Font and typography-related issues and PRs labels Aug 16, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 16, 2022
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my testing (using Twenty Twenty Two and Empty Theme) almost everything works as expected apart from Font Size, which only seems to have an effect on the inner Comments Content and (weirdly) Avatar blocks.

Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my testing (using Twenty Twenty Two and Empty Theme) almost everything works as expected apart from Font Size, which only seems to have an effect on the inner Comments Content and (weirdly) Avatar blocks.

It looks like that's because those blocks already default to a small font size. If that's unset it works as expected. 👍

It feels like there should be a way to scale the font size relatively on parent blocks, but not relevant to this PR.

@aaronrobertshaw
Copy link
Contributor Author

Thanks for reviewing and testing @talldan 👍

It feels like there should be a way to scale the font size relatively on parent blocks, but not relevant to this PR.

Agreed. I'll add it to a follow-up issues section on the tracking issue for these efforts.

@aaronrobertshaw aaronrobertshaw merged commit 45e0fe2 into trunk Aug 18, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/comments-template-typography-support branch August 18, 2022 04:33
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comment Template Affects the Comment Template Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants