Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Date: Add missing typography support #43262

Merged
merged 1 commit into from Aug 17, 2022
Merged

Comment Date: Add missing typography support #43262

merged 1 commit into from Aug 17, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing text-decoration support to the Comment Date block.

Why?

While there might not be a lot of value in text-decoration styles for the comment date block, adding this helps us ensure consistent design tools across blocks.

How?

  • Opts into text decoration support.

Testing Instructions

  1. Load the block editor with a post containing comments
  2. Add a comments block to the post and select the comment's date
  3. Confirm the text decoration control is now available within the Typography panel's ellipsis menu
  4. Experiment with the typography settings
  5. Save and confirm the styles appear on the frontend
  6. Test the new support works for the block via theme.json and global styles.

Screenshots or screencast

Screen.Recording.2022-08-16.at.8.06.46.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Comment Date Affects the Comment Date Block [Feature] Typography Font and typography-related issues and PRs labels Aug 16, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 16, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 16, 2022
Open
6 tasks
ramonjd
ramonjd approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The text decoration control is now available within the Typography panel's ellipsis menu
✅ Comment date styles appear correctly in editor and frontend using different date formats (block and classic themes)
✅ Tested typography for comment date block in theme.json and global styles.

@aaronrobertshaw aaronrobertshaw merged commit b4c853c into trunk Aug 17, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-support-to-comment-date branch August 17, 2022 01:29
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 17, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonjd ramonjd ramonjd approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Comment Date Affects the Comment Date Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aaronrobertshaw @ramonjd @femkreations